Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix "test inject in iso" workflow #612

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Conversation

ldevulder
Copy link
Contributor

It fails on macOS, as Docker needs to be installed before buildx.

@ldevulder ldevulder added the kind/bug Something isn't working label Jan 11, 2023
@ldevulder ldevulder self-assigned this Jan 11, 2023
@ldevulder
Copy link
Contributor Author

ldevulder commented Jan 11, 2023

It's better now: https://github.com/rancher/elemental/actions/runs/3894576982 it seems that there's sill an issue with MacOS but in the build process now).

NOTE: I've removed the arm64 support for now, as there's no ISO for this platform on OBS yet.

It fails on macOS, as Docker needs to be installed before buildx.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
As arm64 ISO is not generated on OBS yet.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
@juadk juadk force-pushed the fix-test-inject-iso-workflow branch 2 times, most recently from 7a1336b to fe26661 Compare January 16, 2023 16:40
@juadk juadk force-pushed the fix-test-inject-iso-workflow branch from fe26661 to d0e747b Compare January 16, 2023 16:46
@ldevulder
Copy link
Contributor Author

Thanks @juadk for the help and tests on MacOS!

@ldevulder ldevulder enabled auto-merge (rebase) January 16, 2023 17:15
Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here!

.github/elemental-iso-add-registration Show resolved Hide resolved
@ldevulder ldevulder merged commit 851a5c4 into main Jan 16, 2023
@ldevulder ldevulder deleted the fix-test-inject-iso-workflow branch January 16, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants