Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/integ: fix failing test #617

Merged
merged 1 commit into from
Jan 17, 2023
Merged

ci/integ: fix failing test #617

merged 1 commit into from
Jan 17, 2023

Conversation

ldevulder
Copy link
Contributor

The checked text has been slightly modified due to refactoring in elemental-cli. See rancher/elemental-cli#404.

@ldevulder ldevulder self-assigned this Jan 17, 2023
@ldevulder
ci/integ: fix failing test
9722f68 
The checked text has been slightly modified due to refactoring in
elemental-cli. See rancher/elemental-cli#404.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
@ldevulder ldevulder enabled auto-merge (rebase) January 17, 2023 15:29
davidcassany
davidcassany approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I did not realize it could have impact that area...

@ldevulder ldevulder merged commit 7dc5c63 into main Jan 17, 2023
@ldevulder ldevulder deleted the fix-integration-tests branch January 17, 2023 15:34
@davidcassany
Copy link
Contributor

I wonder if the change will now only be compatible with Dev, the PR is affecting to all tests? If so probably this is just simpler to remove the modified line or just keep the Finished copying part. I doubt it has much value testing the exact log entry other than to validate it reached that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcassany davidcassany davidcassany approved these changes

Assignees

@ldevulder ldevulder

Labels
area/elemental-cli kind/QA
Projects
Elemental
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldevulder @davidcassany