Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e ui: change how we check that an app is deleted #621

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

juadk
Copy link
Contributor

@juadk juadk commented Jan 19, 2023

This PR should fix a sporadic issue which happens when we check if the cis-benchmark app is deleted.
Broken test: https://github.com/rancher/elemental/actions/runs/3955300594/jobs/6773475455

image

Verification runs:
I would like the test passes 3 times in a row to be sure it is not flaky anymore 😄

  1. https://github.com/rancher/elemental/actions/runs/3958665734 ✔️
  2. https://github.com/rancher/elemental/actions/runs/3959132781 ✔️
  3. https://github.com/rancher/elemental/actions/runs/3960011054 ✔️

@juadk juadk added the kind/QA label Jan 19, 2023
@juadk juadk self-assigned this Jan 19, 2023
@juadk juadk requested a review from ldevulder January 19, 2023 15:44
@ldevulder ldevulder merged commit e73459d into main Jan 19, 2023
@ldevulder ldevulder deleted the fix_sporadic_issue_when_uninstall_apps branch January 19, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants