Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upgradeContainerSpec to ManagedOS and update wrangler #66

Merged
merged 5 commits into from
Mar 23, 2022
Merged

Add upgradeContainerSpec to ManagedOS and update wrangler #66

merged 5 commits into from
Mar 23, 2022

Conversation

mudler
Copy link
Contributor

@mudler mudler commented Mar 23, 2022 •
edited
Loading

This PR adds a upgradeContainer field to ManagedOS. If specified, is used to as container spec for creating the Plan which is consumed by system-upgade-controller. If nothing is specified we fallback to os2 defaults.
This PR also updates wrangler and does pin of some modules, rationale is explained in the individual commits.

  # Overrides the default container created for running the upgrade with a custom one
  # This is optional and used only if specific upgrading mechanisms needs to be applied
  # in place of the default behavior.
  # The image used here overrides ones specified in osImage, depending on the upgrade strategy.
  upgradeContainer:
    image: ubuntu
    command: ["/bin/sh"]
    args: ["-c", "true"]
    env:
    - name: TEST_ENV
      value: testValue

@mudler
Allow to specify a upgradeContainerSpec on ManagedOS
661dfd3 
#59

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler
Run go generate and update wrangler
a00886a 
Also pin golang.org/x/tools to latest, to workaround
golang/go#37617

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler
Update docs
2462aba 
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler
Adapt to new wrangler signal context
2442abc 
rancher/wrangler@9460166

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler mudler changed the title Customize managedos Add upgradeContainerSpec to ManagedOS and update wrangler Mar 23, 2022
@mudler mudler linked an issue Mar 23, 2022 that may be closed by this pull request
ManagedOS upgrade command is hardcoded #59
Closed
davidcassany
davidcassany approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just comment on the headers update

pkg/generated/controllers/rancheros.cattle.io/factory.go Outdated Show resolved Hide resolved
@mudler
Fixup license headers
f0cb6c7 
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler mudler merged commit b1331ab into master Mar 23, 2022
@mudler mudler deleted the customize_managedos branch March 23, 2022 17:27
mudler pushed a commit that referenced this pull request Jun 3, 2022
@davidcassany
Add --reboot and --poweroff flags (#66)
aa7fe62 
Signed-off-by: David Cassany <dcassany@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Itxaka Itxaka Itxaka approved these changes

@davidcassany davidcassany davidcassany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ManagedOS upgrade command is hardcoded
3 participants
@mudler @Itxaka @davidcassany