Drop rancheros-operator from os2 repo #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 25, 2022 10:07
It is now living on https://github.com/rancher-sandbox/rancheros-operator Drops the chart as well. Modifies all scripts so they go the proper way of installing a chart, i.e. adding the repo and installing from the repo directly. Modifies dockerfile to still get the chart into the image as before. Signed-off-by: Itxaka <igarcia@suse.com>
A side effect of the building was that make ci expected mtools to be available for iso building but they werent there and were being provided from other containers as a side effect. This patch makes it so its available in the environment as expected Signed-off-by: Itxaka <igarcia@suse.com>
Itxaka
force-pushed
the
drop_ros_operator
branch
from
74df992
to
3d83897
Compare
set the base requirements on base dapper image, not on the ros-installer image as they are not needed there Signed-off-by: Itxaka <igarcia@suse.com>
Itxaka
force-pushed
the
drop_ros_operator
branch
from
3d83897
to
3b09c42
Compare
mudler
reviewed
Mar 25, 2022
mudler
reviewed
Mar 25, 2022
mudler
approved these changes
Mar 25, 2022
added 2 commits
March 25, 2022 16:16
Signed-off-by: Itxaka <igarcia@suse.com>
There is no need to test the operator anymore from this side as its already tested on its own repo Signed-off-by: Itxaka <igarcia@suse.com>
Itxaka
force-pushed
the
drop_ros_operator
branch
from
4406c15
to
93037bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now living on https://github.com/rancher-sandbox/rancheros-operator
Drops the chart as well.
Modifies all scripts so they go the proper way of installing a chart,
i.e. adding the repo and installing from the repo directly.
Modifies dockerfile to still get the chart into the image as before.
Signed-off-by: Itxaka igarcia@suse.com