ci/ui: Test embedded hardware labels #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juadk
force-pushed
the
676-Test_hardware_labels
branch
from
08657e6
to
1cf22c4
Compare
juadk
force-pushed
the
676-Test_hardware_labels
branch
from
1cf22c4
to
44767ff
Compare
juadk
force-pushed
the
676-Test_hardware_labels
branch
from
44767ff
to
3488b99
Compare
ldevulder
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #676
We test two things in this new test:
Add hardware labels in Machine Registration and make sure we can see them inside YAML
Check we can also see them in machine inventoy after booting a node
Verification Runs
K3s-UI_E2E-Stable_RM ✔️
UI-K3s-OS-Upgrade-Rancher_Stable ✔️
Videos
Configure label and check inside Machine registration test (from 8:13 to the end):
https://user-images.githubusercontent.com/6025636/223232322-7e6932d1-f6e5-4c2e-8b83-a011f036ef59.mp4
Machine inventory check (from 0:20 to 1:30)
https://user-images.githubusercontent.com/6025636/223231675-6dd8ca0a-db69-497b-9361-ee3bb1f87073.mp4