Do not expand COS_PERSISTENT by default #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcassany
force-pushed
the
do_not_expand_disk_by_default
branch
from
d9fbd53
to
d11bca9
Compare
This commit drops the expansion cloud-init step for COS_PERSISTENT partition. The installation already uses all available size by default there is not need to attempt a resize on every boot. In addition this commit also updates the persistent volumes configuration to be aligned with the latest elemental-toolkit changes. Now volumes are set as part of the kernel arguments at boot and not as part of the cloud-init setup. This prevents including filesystem label literals within the immutable OS. Signed-off-by: David Cassany <dcassany@suse.com>
davidcassany
force-pushed
the
do_not_expand_disk_by_default
branch
from
d11bca9
to
2dc2087
Compare
ldevulder
approved these changes
Mar 17, 2023
fgiudici
approved these changes
Mar 17, 2023
|
I blocked it as I'd like to merge it after verifying rancher/elemental-toolkit#1743 solves the issue. The patch here I believe it prevents the race condition to happen so we would not hit the corner case that the mentioned PR aims to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit drops the expansion cloud-init step for COS_PERSISTENT partition. The installation already uses all available size by default there is not need to attempt a resize on every boot.
In addition this commit also updates the persistent volumes configuration to be aligned with the latest elemental-toolkit changes. Now volumes are set as part of the kernel arguments at boot and not as part of the cloud-init setup. This prevents including filesystem label literals within the immutable OS.
Related to #732