Ensure names are unique for all stages #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Cassany <dcassany@suse.com>
|
Shouldn't this be detected by yip (iow isn't this a yip bug) ? |
Yes, this is a yip issue. So this is a simple, sane and fully functional workaround for now. |
|
Already opened the yip counter part mudler/yip#88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are suffering from a small yip regression. Since v1.0.0 yip uses a DAG (Directed Acyclic Graph) to sort and relate all the required executions, allowing parallel executions (we have not played with it so far). However one of the side effects is that the dag structures items in a map internally using the step name if provided, hence having two steps with the same name causes the step overwrite.
Exactly this is what is happening in the layout setup, we have two steps for that (recovery and non recovery) with the same name, so one of the two gets ignored...
Fixes #829