Convert bootstrapping test scripts in go #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldevulder
force-pushed
the
convert-bootstrapping-test-scripts-in-go
branch
10 times, most recently
from
41e5b1a
to
08b8133
Compare
ldevulder
force-pushed
the
convert-bootstrapping-test-scripts-in-go
branch
3 times, most recently
from
139a826
to
3b75342
Compare
ldevulder
force-pushed
the
convert-bootstrapping-test-scripts-in-go
branch
5 times, most recently
from
41cec35
to
e5cb037
Compare
This is helpful to have the trace of all steps of a test. Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
ldevulder
force-pushed
the
convert-bootstrapping-test-scripts-in-go
branch
from
e5cb037
to
d3ab414
Compare
mudler
reviewed
May 2, 2022
mudler
pushed a commit
that referenced
this pull request
Jun 3, 2022
Signed-off-by: David Cassany <dcassany@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #62.
NOTE: for this version, as a TTY is needed for
virt-installI still use a shell script called withscriptcommand. I will do some tests to replace this purely in GO, but more for another version. Same for the HTTP server, I have some Go code but it's not working as expected, I will try to fix this later.