-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use build-host for build process #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
ef605f8
to
a5886c4
Compare
a5886c4
to
7dd5ac4
Compare
The build issue is due to the fact that all runs directly on the runner and not on an container image (Ubuntu in that case), on it to fix this. |
0986778
to
8b28eb0
Compare
I still have this error: Even after forcing the build step to use an Ubuntu image... This PR was to reduce build time by using a self hosted runner but I really don't know how to workaround this error... So better to close it for now I think. |
I finally found why Here a working test:
And here the failing one:
The domain type is EDIT: |
Ok so I think I understood the process and why KVM accel is set: it's detected when Which leads me to ask: why is this so complicated?? But this is really difficult to understand TBH... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rebase is needed |
1d174b1
to
18bfcaf
Compare
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
As E2E test sporadically fails because of timeout. Signed-off-by: Loic Devulder <ldevulder@suse.com>
As the worker has enough available CPU and RAM. Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Patch from Itxaka Serrano <igarcia@suse.com> Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
770d564
to
49d6157
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d282c73
to
31079ee
Compare
@mjura @ldevulder - what is this waiting for ? |
A verification run that works... I have issue and I'm currently doing manual tests to understand why (could be due to some renaming change). If I can fix in this PR I will do, otherwise I will merge this one and create new to fix. EDIT: latest verification run is green! |
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
31079ee
to
1588df9
Compare
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
This should speedup the build processes.
E2E verification runs:
with standard selfhosted runner conf: https://github.com/rancher/elemental/actions/runs/2529263149/attempts/1with_work
on tmpfs andtuned
configured for performance: https://github.com/rancher/elemental/actions/runs/2529263149/attempts/2 (it seems that the I/O is degraded, but why?)withtuned
configured for performance: https://github.com/rancher/elemental/actions/runs/2529263149/attempts/3