Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a note for pre-releases as semver ignores them by default #114

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Adds a note for pre-releases as semver ignores them by default #114

merged 1 commit into from
Feb 28, 2024

Conversation

0xavi0
Copy link
Contributor

@0xavi0 0xavi0 commented Feb 26, 2024

Adding this to clarify imagescan with pre-releases.

Refers to: rancher/fleet#2096

@0xavi0
Adds a note for pre-releases as semver ignores them by default
7148f81 
Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
@0xavi0 0xavi0 requested a review from a team as a code owner February 26, 2024 16:05
@0xavi0 0xavi0 mentioned this pull request Feb 26, 2024
Merged
weyfonk
weyfonk approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@weyfonk weyfonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xavi0 0xavi0 merged commit 3eaf241 into rancher:main Feb 28, 2024
@mmartin24 mmartin24 mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weyfonk weyfonk weyfonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xavi0 @weyfonk