[v0.5] ensure valid release name for agent #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 1, 2023 13:40
Bundles that were created directly could still have an invalid bundle name.
Directly created bundles should use the same sanitization as bundles created via `fleet apply`. We still don't allow '.', because it's not DNS label safe.
|
I have trouble testing this locally. This is not ready yet. |
added 2 commits
March 2, 2023 12:01
Adding the token prefix to the cluster name could exceed 63 characters and the ClusterRegistrationToken would not have been created. The error was silently dropped.
`^1.19` is equivalent to `>=1.19.0 <2.0.0`, depending on the github runner's cache, we might get a new version than expected. See: https://github.com/npm/node-semver#ranges
thardeck
approved these changes
Mar 2, 2023
|
rancher/rancher#40684 got closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1353
Refers to rancher/rancher#40684