Add sharding to Fleet deployments in CI workflows running end-to-end tests #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similarly to what has been done for the regular CI workflow for end-to-end tests, this workflow needs the following, added here: * a Fleet deployment with sharding enabled * a metrics tests run
Now that sharding end-to-end test cases can be run without test infra, they are run in AKS and GKE workflows. Those workflows therefore require Fleet to be deployed with sharding enabled.
p-se
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With sharding end-to-end tests now running without needing test infra (see #2396), those tests will run in AKS and GKE workflows, where Fleet deployments need sharding enabled to allow those tests to pass.
This PR also fixes Fleet deployments in a similar way for the nightly CI workflow.
This should fix CI failures such as this one (nightly) and that one (AKS).