Add git to gitjob image #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-git tries to use git if repo can't be found. This was causing misleading error messages.
weyfonk
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-gittries to use thegitbinary if a repository can't be found. This was causing misleading error messages. This PR adds the git binary to thegitjobimage.For example:
git@github.com/go-git/go-git.gitwas returning the errorError fetching latest commit: Exec: "git": executable file not found in $PATHWith the changes from this PR the error is:
Error fetching latest commit: repository not foundrefers to rancher/rancher#43499