Add azure devops webhook support #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Process multiple git push events in azure and bitbucket.
raulcabello
force-pushed
the
azure-webhooks-v0.8
branch
from
eaf714e
to
bbe498e
Compare
raulcabello
changed the title
weyfonk
reviewed
Jan 9, 2024
raulcabello
force-pushed
the
azure-webhooks-v0.8
branch
from
ae90b41
to
41bcb20
Compare
raulcabello
force-pushed
the
azure-webhooks-v0.8
branch
from
41bcb20
to
31abd19
Compare
weyfonk
approved these changes
Jan 15, 2024
| @@ -0,0 +1,110 @@ | |||
| // File copied from https://github.com/go-playground/webhooks/blob/master/azuredevops/azuredevops.go | |||
There was a problem hiding this comment.
nit: I think it could make sense to copy the corresponding test file over as well, just to be on the safe side. How do you see it?
There was a problem hiding this comment.
we would also need to copy all the testdata files.. https://github.com/go-playground/webhooks/blob/master/azuredevops/azuredevops_test.go#L63
I would avoid copying all those files. Should we leave it without the test or maybe we can just transfer my fork to the fleet org and use the fork instead?
There was a problem hiding this comment.
Let's leave it without the test for now; in the meantime, I'll be watching your PR so that we can switch back to using upstream ASAP. Thanks for clarifying :)
This was referenced Jan 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
AzureDevOpswebhook.Azurewill notifygitjobwhen a new commit has been pushed, then a Job will be created with the latest changes. It works the same way as the webhooks for other git providers.The https://github.com/go-playground/webhooks library we use for parsing the webhooks doesn't provide verification in Azure. I created a PR for adding basic auth verification in Azure. The file from this PR is copied in fleet in the meantime.
refers to rancher/fleet#1998