This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
[feature] implement kim-native credentials #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `kim builder login` that works very much like `docker login`
but instead stores the resulting Docker `config.json` in a kubernetes
secret in the builder namespace. This secret is rendered to disk in a
temp directory for `build` operations (to satisfy buildkit) but is
leveraged as an in-memory keyring for shipping auth credentials for
`push` / `pull` operations. If the secret setup by the `login` cli
operation does not exist, kim reverts to the existing behavior of
consulting the `${DOCKER_CONFIG}/config.json` for registry credentials.
Addresses rancher#64
Signed-off-by: Jacob Blain Christen <jacob@rancher.com>
dweomer
force-pushed
the
feat/64/builder-login
branch
from
0e9252f
to
2173381
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
kim builder loginthat works very much likedocker loginbut instead stores the resulting Docker
config.jsonin a kubernetessecret in the builder namespace. This secret is rendered to disk in a
temp directory for
buildoperations (to satisfy buildkit) but isleveraged as an in-memory keyring for shipping auth credentials for
push/pulloperations. If the secret setup by theloginclioperation does not exist, kim reverts to the existing behavior of
consulting the
${DOCKER_CONFIG}/config.jsonfor registry credentials.Addresses #64
Fixes #22
Signed-off-by: Jacob Blain Christen jacob@rancher.com