Add support for openstack server groups #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu1as
force-pushed
the
add-openstack-server-group-support
branch
from
781876f
to
57fe830
Compare
|
Anything wrong with this PR? I tested it with a custom Rancher server image and it seems to work fine. |
jacobbaek
added a commit
to jacobbaek/machine
that referenced
this pull request
Jan 28, 2022
|
This PR's changes look good to me too. |
|
Hello ! |
|
This feature would be very helpful for HA. |
|
Hiya, is there something holding this back ? We only have Openstack as a provider and this is of real concern. Thanks very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR adds support for specifying a server group in OpenStack node templates, so that it's possible to ensure that for example master nodes were scheduled on different OpenStack compute nodes.
The server group has to be created and configured in OpenStack beforehand. It would be cool if Rancher could manage the server group itself, but I guess that logic is too much for a node driver, so I kept it simple here.
Related issues: