Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Drone CI to GitHub Action #246

Merged
merged 1 commit into from
May 8, 2024
Merged

Migrate from Drone CI to GitHub Action #246

merged 1 commit into from
May 8, 2024

Conversation

jiaqiluo
Copy link
Member

@jiaqiluo jiaqiluo commented Apr 26, 2024

Some notes on this PR:

  • It is raised from a branch in the rancher/machine repo for the CI to be triggered ( the CI will not run if the PR is from a forked repo AND the target repo does not contain a workflow file).
  • The FOSSA step is expected to fail, and per the EIO's suggestion, the directive continue-on-error: true is used to unblock other jobs( in the event of pushing a tag)
  • The reference for how to use Docker action to build mult-arch image: https://docs.docker.com/build/ci/github-actions/multi-platform/

Dev validation:

SURE-7998

@jiaqiluo jiaqiluo marked this pull request as ready for review April 26, 2024 17:04
@jiaqiluo jiaqiluo requested a review from a team April 29, 2024 17:29
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
HarrisonWAffel
HarrisonWAffel previously approved these changes Apr 29, 2024
@HarrisonWAffel HarrisonWAffel requested a review from a team April 29, 2024 22:03
@HarrisonWAffel HarrisonWAffel requested a review from a team May 1, 2024 17:13
@jiaqiluo jiaqiluo merged commit 69fbcdd into master May 8, 2024
1 check passed
@jiaqiluo jiaqiluo deleted the migrate-to-gha branch May 8, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants