Allow cloud-config to Work on Distros with Read-Only /usr Partitions #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jiaqiluo @kinarashah Could this get some attention? :) Running into this issue as well. |
jakefhyde
requested changes
Sep 27, 2024
| @@ -451,7 +451,8 @@ func updateUserdataFile(driverOpts *rpcdriver.RPCFlags, machineName, hostname, u | |||
| // on how hostnames are set in cloud-config (userdata) | |||
| func writeCloudConfig(machineName, encodedData, machineOS, hostname string, cf map[interface{}]interface{}, newUserDataFile *os.File) error { | |||
| command := "sh" | |||
| path := "/usr/local/custom_script/install.sh" | |||
| // allow the script to work on distros with read-only /usr partitions | |||
| path := "/var/run/install.sh" | |||
There was a problem hiding this comment.
Suggested change
| path := "/var/run/install.sh" | |
| path := "/opt/rancher-system-agent/install.sh" |
I believe we install the system agent within that directory anyway if /usr is not writable, so I'd rather reuse that if possible.
There was a problem hiding this comment.
That path wouldn't exist on the machine initially. /var/run is the most portable path that could be used, since it will definitely exist and will always be writable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to allow cloud-config to work on distros with read-only /usr partitions, such as Flatcar. It simply changes the hard-coded path from under the
/usrtree to under the/var/runtree, which is more portable.Please note that without this change bootstrapping Flatcar RKE2 nodes in Rancher is not possible.