Allow to put Reason in controller.ForgetError #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Norman Condition automatically generate condition information based on the error the handler would return in Condition.Do function. handler function usually return 2 types of error. the error can be ignored and the error can not be ignored. According to current implementation, Condition.Do function generate condition with error state even if handler return error can be ignored. The error that can be ignored should be ignored in the context of condition as well. So this commit introduce new field which is Reason to ForgetError so that the developer can put special reason other than Error when ForgetError is expected to happen by expected procedure like provisioning and wait for something and Norman Condintion respect to this field when try to generate condition information based on error This solution will help us to fix this rancher bug rancher/rancher#15907
jordanjean
pushed a commit
to jordanjean/norman
that referenced
this pull request
Jan 7, 2020
Added refresh argument on rancher2_catalog resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Norman Condition automatically generate condition information based on
the error the handler would return in Condition.Do function.
handler function usually return 2 types of error. the error can be
ignored and the error can not be ignored.
According to current implementation, Condition.Do function generate
condition with error state even if handler return error can be ignored.
The error that can be ignored should be ignored in the context of
condition as well.
So this commit introduce new field which is Reason to ForgetError so
that the developer can put special reason other than Error when
ForgetError is expected to happen by expected procedure like
provisioning and wait for something and Norman Condintion respect to
this field when try to generate condition information based on error
This solution will help us to fix this rancher bug
rancher/rancher#15907