This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
Support vSphere network protocol profiles #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2018
|
Here is official documentation for vSphere vApp properties and for Network protocol profile. You can see that vSphere haven't type or expression for passing IP in CIDR format. Same for DNS properties. |
|
It seems that this feature makes sense. I have already recommended it to my colleague, looking forward to the feedback of other PRs. |
|
@niusmallnan who are we waiting on for an LGTM? |
|
@cjellick I can review this today and merge it if possible. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of rancher/rancher#15817
Added
guestinfoparams:interface.<n>.ip.<m>.netmaskdns.serversdns.domainsbecause vSphere doesn't provide IP address in CIDR format and have one field for DNS servers and one for DNS search paths.