Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#455 How to set hostNetwork:true for k8s 1.21 and up #732

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

martyav
Copy link
Contributor

@martyav martyav commented Jul 19, 2023

Fixes #455

The information on this existed, but wasn't really linked to directly. This adds links to where in the UI to go, and what to edit.

@martyav martyav requested a review from btat July 21, 2023 14:39
@btat
Copy link
Contributor

btat commented Jul 26, 2023

@martyav the references linked don't mention RKE2. Could you confirm if it's applicable there. If it is applicable, the YAML input needs to be double checked as well as it may not be the same as RKE1.

@martyav
Copy link
Contributor Author

martyav commented Jul 26, 2023

@btat Thank you for catching that. According to the RKE2 docs, the user needs to set their own network policy (the page has an example): https://docs.rke2.io/known_issues#ingress-in-cis-mode

@martyav martyav requested a review from dereknola August 2, 2023 14:59
@martyav
Copy link
Contributor Author

martyav commented Aug 2, 2023

@dereknola Hey, Derek. I'm tagging you in because I saw you worked on the RKE2 page I cited. Could you provide a technical review/advice on wording?

@martyav martyav requested a review from jiaqiluo August 8, 2023 20:55
@martyav
Copy link
Contributor Author

martyav commented Aug 8, 2023

Tagging @jiaqiluo in hopes to answer this question:

@martyav the references linked don't mention RKE2. Could you confirm if it's applicable there. If it is applicable, the YAML input needs to be double checked as well as it may not be the same as RKE1.

@jiaqiluo
Copy link
Member

jiaqiluo commented Aug 8, 2023

Tagging @jiaqiluo in hopes to answer this question:

@martyav the references linked don't mention RKE2. Could you confirm if it's applicable there. If it is applicable, the YAML input needs to be double checked as well as it may not be the same as RKE1.

hi @martyav, AFAIK, the change of the default value hostNetwork from true to false happens on the RKE1 side only.

@btat btat merged commit 4b2fadc into rancher:main Aug 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to set hostNetwork:true for k8s 1.21 and up
3 participants