Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand automatic testing to include all CLI commands #3383

Closed
1 of 6 tasks
superseb opened this issue Sep 21, 2023 · 2 comments
Closed
1 of 6 tasks

Expand automatic testing to include all CLI commands #3383

superseb opened this issue Sep 21, 2023 · 2 comments
Assignees

Comments

@superseb
Copy link
Contributor

superseb commented Sep 21, 2023

Expand our current DinD CI to include all CLI commands

@manuelbuil manuelbuil self-assigned this Nov 3, 2023
@manuelbuil
Copy link
Contributor

Update: I carried out a quick investigation on possible options to do this:

1 - Enhance our current CI which uses docker to create nodes. But this is limited and not testing a typical rke deployment
2 - Change CI and start using nested virtualization in the drone ec2 to create the extraVM we need. Run rke binary in drone-runner and deploy k8s in the extraVM
3 - Change CI and add terraform code to what gets executed in drone-runner. That terraform code creates the extraVM. Run rke binary in drone-runner and deploy k8s in the extraVM
4 - Change CI. Stop using drone and start using github-actions + macos + vagrant to do the nested virtualization. But the cpu resources are quite limited and it has currently a bug

EOI is already using option 2 for harvester, so we are going to prioritize that one as we can tap on that already existing WoW and experience. The great thing is that they'll take care of creating the extra VM for us, which is awesome. My main concern is price, as aws-ec2 instances that allow nested virtualization cost x10 more but as rke1 does not have a lot of PRs, the price should not be prohibitively.

EOI team is currently building a PoC to verify this. Once they are ready we'll give it a try and hopefully is fulfills our needs!

@manuelbuil
Copy link
Contributor

Kinara commented that after upgrades some features get broken. We should test it too!

@superseb superseb closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants