Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport v1.2] addon jobs stuck removing #2797

Conversation

jakefhyde
Copy link
Contributor

@jakefhyde jakefhyde commented Jan 4, 2022

Backport of #2796

This adds an additional check to ensure that a job isn't currently being deleted before attempting to create a new one and proceed with reconciliation. If the job is being deleted, we now attempt to wait for either completion, or timeout and attempt reconciliation again.

Related Issue: rancher/rancher#36037

Closed in favor of #2801

@jakefhyde jakefhyde requested review from snasovich, kinarashah and a team January 4, 2022 22:33
@jakefhyde jakefhyde force-pushed the 35750-backport-v1-2-addon-jobs-stuck-removing branch from d493aae to ef390dc Compare January 4, 2022 23:53
Copy link
Collaborator

@snasovich snasovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on it being the same as #2796.
If no changes are needed there, feel free to merge this one.

@jakefhyde
Copy link
Contributor Author

Closed in favor of #2801

@jakefhyde jakefhyde closed this Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants