support 1.24 #2948
Merged
support 1.24 #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiaqiluo
force-pushed
the
support-1-24
branch
3 times, most recently
from
85db5ac
to
ddc575d
Compare
jiaqiluo
force-pushed
the
support-1-24
branch
2 times, most recently
from
eb4f47f
to
34b7db9
Compare
kinarashah
previously approved these changes
Jun 29, 2022
kinarashah
reviewed
Jun 29, 2022
… enable_cri_dockerd is not configured; 2. drop the flag --address when the cluster version >= 1.24 in the DinD case
kinarashah
approved these changes
Jun 29, 2022
rosskirkpat
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Changes in this PR:
cri-dockerdto be enabled when the cluster version >= 1.24 and the optionenable_cri_dockerdis not configured in the cluster.yml fileTest:
This PR has been tested locally by pointing the KDM to my forked which contains the template for
1.24.1-rancher1-1.1.24.1-rancher1-1cluster succeeded.1.24.1-rancher1-1cluster failed as expected whenenable_cri_dockerd=falseis set in the cluster.yml filev1.23.6-rancher1-1to1.24.1-rancher1-1also succeeded.Related PRs: