Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update automated_upgrade.md to indicate change in node-role #1387

Closed
davidnuzik opened this issue Jul 20, 2021 · 2 comments
Closed

[Docs] Update automated_upgrade.md to indicate change in node-role #1387

davidnuzik opened this issue Jul 20, 2021 · 2 comments
Assignees
@briandowns
Labels
kind/documentation Improvements or additions to documentation
Milestone
v1.21.3+rke2r1

Comments

@davidnuzik
Copy link
Contributor

davidnuzik commented Jul 20, 2021 •
edited
Loading

I believe upstream changed node-role labels, or they will soon deprecate /master node-role. The SUC upgrade plan outlined in https://github.com/rancher/rke2/blob/master/docs/upgrade/automated_upgrade.md in #Configure plans section may need an update. I believe that node-role.kubernetes.io/master is just node-role.kubernetes.io/control-plane now. I believe that we mention /master in the doc. Review the #Configure plans section and see if it needs an update.

There is more context in our internal slack and I will share this information with you.
@davidnuzik davidnuzik added the kind/documentation Improvements or additions to documentation label Jul 20, 2021
@davidnuzik davidnuzik added this to the v1.21.3+rke2r1 milestone Jul 20, 2021
@davidnuzik
Copy link
Contributor Author

@manuelbuil may know more, and/or be able to point you to this change.

@briandowns
Copy link
Contributor

@manuelbuil made a PR for this yesterday. Here's the link. https://github.com/rancher/rke2/pull/1368/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@briandowns briandowns

Labels
kind/documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.21.3+rke2r1
Development

No branches or pull requests
3 participants
@briandowns @davidnuzik @fapatel1