-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding agent service sub command for Windows #1281
Conversation
Should this functionality be added to k3s and carried into RKE2? That's what we did for the etcd subcommands. Also, take a look at how the etcd subcommands are and try to mirror that approach for consistency's sake. |
ya we already had this convo, no one committing to windows in k3s so no point in the commands there. i agree it SHOULD be there but that requires us to get to a point where k3s works in windows too |
Fair enough. I had forgotten about that convo. |
2306a5a
to
baea886
Compare
87b0964
to
dc2d71c
Compare
dc2d71c
to
7cc8762
Compare
adds the service subcommand to agent which can add/delete a windows service for rke2 via the windows service manager. the agent will only work with a config yaml so --config is a required param and get's passed/set on the service via args so ultimately the call to run the agent will default to
rke2 agent --config /etc/rancher/k3s/config.yaml
#1279