Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding agent service sub command for Windows #1281

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

luthermonson
Copy link
Contributor

@luthermonson luthermonson commented Jul 12, 2021

adds the service subcommand to agent which can add/delete a windows service for rke2 via the windows service manager. the agent will only work with a config yaml so --config is a required param and get's passed/set on the service via args so ultimately the call to run the agent will default to rke2 agent --config /etc/rancher/k3s/config.yaml

#1279

@luthermonson luthermonson requested a review from a team as a code owner July 12, 2021 21:14
@luthermonson luthermonson changed the title adding agent service sub command for windows [wip] adding agent service sub command for windows Jul 12, 2021
pkg/cli/cmds/agent_service_windows.go Outdated Show resolved Hide resolved
pkg/cli/cmds/agent_service_windows.go Outdated Show resolved Hide resolved
pkg/cli/cmds/agent_service_windows.go Outdated Show resolved Hide resolved
pkg/cli/cmds/agent_service_windows.go Outdated Show resolved Hide resolved
@briandowns
Copy link
Contributor

Should this functionality be added to k3s and carried into RKE2? That's what we did for the etcd subcommands. Also, take a look at how the etcd subcommands are and try to mirror that approach for consistency's sake.

@luthermonson
Copy link
Contributor Author

Should this functionality be added to k3s and carried into RKE2? That's what we did for the etcd subcommands. Also, take a look at how the etcd subcommands are and try to mirror that approach for consistency's sake.

ya we already had this convo, no one committing to windows in k3s so no point in the commands there. i agree it SHOULD be there but that requires us to get to a point where k3s works in windows too

@briandowns
Copy link
Contributor

Should this functionality be added to k3s and carried into RKE2? That's what we did for the etcd subcommands. Also, take a look at how the etcd subcommands are and try to mirror that approach for consistency's sake.

ya we already had this convo, no one committing to windows in k3s so no point in the commands there. i agree it SHOULD be there but that requires us to get to a point where k3s works in windows too

Fair enough. I had forgotten about that convo.

@luthermonson luthermonson changed the title [wip] adding agent service sub command for windows Adding agent service sub command for Windows Jul 12, 2021
pkg/cli/cmds/agent_service_windows.go Outdated Show resolved Hide resolved
@luthermonson luthermonson merged commit 87acb68 into rancher:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants