Refactored how we start calico with kubelet context to cancel #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipsj
force-pushed
the
refactor-win-calico
branch
from
bc04edf
to
067ef26
Compare
phillipsj
changed the title
briandowns
reviewed
Aug 13, 2021
briandowns
reviewed
Aug 13, 2021
phillipsj
force-pushed
the
refactor-win-calico
branch
from
067ef26
to
0877c37
Compare
briandowns
reviewed
Aug 16, 2021
brandond
requested changes
Aug 16, 2021
phillipsj
force-pushed
the
refactor-win-calico
branch
2 times, most recently
from
c0a0182
to
dd0bf98
Compare
brandond
requested changes
Aug 16, 2021
phillipsj
force-pushed
the
refactor-win-calico
branch
from
dd0bf98
to
21f3663
Compare
This addresses a few lingering issues that really cleans up our implementation. Signed-off-by: Jamie Phillips <jamie.phillips@suse.com>
phillipsj
force-pushed
the
refactor-win-calico
branch
from
21f3663
to
e874140
Compare
briandowns
approved these changes
Aug 17, 2021
brandond
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
We needed to rework how we were handling the startup for Calico node and felix. We also discovered a few additional issues related to some tweaks that needed to be corrected.
Types of Changes
Bugfix
Verification
Deploy a windows node with no error in the log files.
Linked Issues
Further Comments