Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calico image to v3.28.0-build20240625 #6257

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

galal-hussein
Copy link
Contributor

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
@galal-hussein galal-hussein requested a review from a team as a code owner June 25, 2024 23:56
@@ -30,7 +30,7 @@ xargs -n1 -t docker image pull --quiet << EOF >> build/images-core.txt
EOF

xargs -n1 -t docker image pull --quiet << EOF > build/images-canal.txt
${REGISTRY}/rancher/hardened-calico:v3.28.0-build20240528
${REGISTRY}/rancher/hardened-calico:v3.28.0-build20240625
${REGISTRY}/rancher/hardened-flannel:v0.25.3-build20240605
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flannel version here needs to be bumped as well - v3.28.0-build2024062502 included a flannel bump but wasn't ever pulled through.

[�[36mBASICS�[m] -docker.io/rancher/hardened-flannel:v0.25.3-build20240605
[�[36mBASICS�[m] +docker.io/rancher/hardened-flannel:v0.25.4-build20240610
Suggested change
${REGISTRY}/rancher/hardened-flannel:v0.25.3-build20240605
${REGISTRY}/rancher/hardened-flannel:v0.25.4-build20240610

Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.09%. Comparing base (ecd385d) to head (895b263).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6257   +/-   ##
=======================================
  Coverage   26.09%   26.09%           
=======================================
  Files          32       32           
  Lines        2698     2698           
=======================================
  Hits          704      704           
  Misses       1948     1948           
  Partials       46       46           
Flag Coverage Δ
inttests 9.82% <ø> (ø)
unittests 18.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galal-hussein galal-hussein merged commit f01072a into rancher:master Jun 28, 2024
6 checks passed
iamsarthakk pushed a commit to iamsarthakk/rke2 that referenced this pull request Aug 19, 2024
* Update calico image to v3.28.0-build20240625

Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>

* update flannel image to v0.25.4-build20240610

Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>

---------

Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants