🌱 Cleanup v1 cluster before creating v3 clusters on upgrade #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
force-pushed
the
cleanup-v1-cluster-after-v3-migration
branch
4 times, most recently
from
8d7169f
to
9b1f21a
Compare
alexander-demicev
previously approved these changes
Jun 21, 2024
salasberryfin
previously approved these changes
Jun 21, 2024
Danil-Grigorev
dismissed stale reviews from salasberryfin and alexander-demicev
via
ffb1de7
Danil-Grigorev
force-pushed
the
cleanup-v1-cluster-after-v3-migration
branch
from
ffb1de7
to
4fcec14
Compare
4 tasks
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
- Add e2e tests, verifying the added migration functionality Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
cleanup-v1-cluster-after-v3-migration
branch
from
4fcec14
to
78d3b6c
Compare
alexander-demicev
approved these changes
Jun 24, 2024
furkatgofurov7
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Perform automatic provisioning cluster removal on upgrade with
v3 clustersfeature flag enabled.In case of a duplicate cluster entries, a user can re-run the upgrade without settings change.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: