-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check agent deployment based on Ready
condition
#591
Check agent deployment based on Ready
condition
#591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Danil-Grigorev. Just added a nit to align log message with new condition. Otherwise, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Seems like neither
|
f647a49
to
c91f099
Compare
status.ready
and ready
conditionReady
condition
c91f099
to
bfc73f5
Compare
4d00729
to
323b721
Compare
- Prevent executing cluster import until the child cluster manifests are fully removed. - e2e: Rely on crust-gather for logs collection - Check for cleanup job before import Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
3a8f2a2
to
dffc6f2
Compare
What this PR does / why we need it:
status.agentDeployed
and a corresponding condition in the management v3 cluster is not reflecting if the agent manifests are actually there at all times. If the old manifests are getting removed by cluster re-import or migration, new manifests can be purged by this as well.Ready
condition should be better reflecting if turtles need to stop applying manifests.Rancher is performing cleanup job with: https://github.com/rancher/rancher/blob/1c2b815c8dd66e141b21630904127adc8e03c3de/pkg/controllers/management/usercontrollers/controller.go#L289
We need to check for the job existence before performing import operation, and wait for the job and previous manifests to be gone if those are present.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #587
Special notes for your reviewer:
Checklist: