Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EtcdMachineSnapshot controller #708

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Add EtcdMachineSnapshot controller #708

merged 3 commits into from
Sep 3, 2024

Conversation

furkatgofurov7
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 commented Aug 30, 2024 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #499

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@furkatgofurov7 furkatgofurov7 requested a review from a team as a code owner August 30, 2024 12:18
alexander-demicev
alexander-demicev requested changes Sep 2, 2024
View reviewed changes
Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of small comments, thanks for setting up the skeleton

exp/etcdrestore/controllers/etcdmachinesnapshot_controller.go Outdated Show resolved Hide resolved
exp/etcdrestore/controllers/etcdmachinesnapshot_controller.go Outdated Show resolved Hide resolved
exp/etcdrestore/controllers/etcdmachinesnapshot_controller.go Outdated Show resolved Hide resolved
@furkatgofurov7
Add EtcdMachineSnapshot controller
a2893c8 
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7 furkatgofurov7 force-pushed the add-etcdmachinesnapshot-ctrl branch 3 times, most recently from 80bae37 to ee7b94c Compare September 3, 2024 08:10
@furkatgofurov7
Address review comments
4c1bbb4 
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7
Deploy CAPRKE2 as default bootstrap/ctpl provider in dev setup script
7abfaba 
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
alexander-demicev
alexander-demicev approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge the PR as it is and improve in follow-ups

exp/etcdrestore/controllers/etcdmachinesnapshot_controller.go Show resolved Hide resolved
exp/etcdrestore/controllers/etcdmachinesnapshot_controller.go Show resolved Hide resolved
exp/etcdrestore/controllers/etcdmachinesnapshot_controller.go Show resolved Hide resolved
exp/etcdrestore/controllers/etcdmachinesnapshot_controller.go Show resolved Hide resolved
exp/etcdrestore/controllers/etcdmachinesnapshot_controller.go Show resolved Hide resolved
exp/etcdrestore/controllers/etcdmachinesnapshot_controller.go Show resolved Hide resolved
@alexander-demicev alexander-demicev merged commit 129906a into rancher:main Sep 3, 2024
9 checks passed
@furkatgofurov7 furkatgofurov7 deleted the add-etcdmachinesnapshot-ctrl branch September 3, 2024 12:57
@furkatgofurov7 furkatgofurov7 mentioned this pull request Sep 4, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-demicev alexander-demicev alexander-demicev approved these changes

@Danil-Grigorev Danil-Grigorev Danil-Grigorev approved these changes

Assignees
No one assigned
Labels
kind/feature
Projects
CAPI & Hosted Kubernetes providers (EKS/AKS/GKE)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[etcdsnapshot&restore] Implement ETCDMachineSnapshot controller
3 participants
@furkatgofurov7 @alexander-demicev @Danil-Grigorev