This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Check v1.NodeStatus data is nil before executing mapping in OSInfo #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This os_info mapper is used for v1.NodeStatus but there is some case that mapper is evaluated when v1.NodeStatus is nil. For example, when the user try to create v3.Node by calling API(POST /v3/nodes). So we should check data is nil or not before executing mapper in order to prevent from trying to use data(nil) as map inside OSInfo.FromInternal
ukinau
changed the title
ukinau
changed the title
|
LGTM. @ukinau Is there an use case that you need to call /v3/nodes to create nodes? |
|
Yes there is. But currently if we create cluster with nodeDriver like OpenStack on GUI, nodepool is created/used for the cluster and node will be indirectly created by nodepool controller. This behaviour itself is good to us but the problem is that it's not easy to delete specific node in the case of node which is created by nodepool. If we want to delete specific node which is not last node in nodepool, we need to do 3 things to delete.
This is not convenient for us, That's why we started to consider to use /v3/nodes API directly. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user call POST /v3/nodes API to create node, v1.NodeStatus doesn't exist and mapper is evaluated with nil and cause following panic because this mapper try to treat nil data as map,
In order to prevent from causing such a panic, we need to check "data is nil or not" before try to set any value against data. This commit will solve this problem rancher/rancher#14867