Add static region list for (bootstrap) authentication to a subscribed… #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westlywright
approved these changes
Dec 3, 2020
|
@jlamillan Does this need to be in the next 2.5 release? If so, would you mind opening one more backport PR for the 2.5-fixes branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR resolves a "chicken-and-egg" problem in the OCI node and OKE cluster drivers where a user is required to authenticate against a region they are subscribed to to in order to access the OCI API, but retrieving that list of available regions itself requires authentication.
We had previously worked around this issue by defaulting to
us-phoenix-1region. However, this does not work if the user is not subscribed to this region. The fix here is to add and maintain a static baootstrap list of available regions that the two drivers can share - everything else will continue to be fetched dynamically from the API.Types of changes
Bugfix, New feature
Linked Issues
rancher-plugins/kontainer-engine-driver-oke#20
Further comments
This should probably be back-ported to 2.4 as well.