-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker 24.0.x support #5136
Add docker 24.0.x support #5136
Conversation
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/backport v2.8.next1 release-2.8 |
@rak-phillip @mantis-toboggan-md to confirm only 24.0.x is needed and not the referenced 25.0.x in the issue? if so can the original issue be updated? Edit: worth mentioning rancher/dashboard#10841 just came in too |
@richard-cox Yes. When a version
Absolutely, we'll add some context over there. |
More weirdness, as always @rak-phillip thanks for your explanation and patience. Feels like we should be generating these automatically backwards from the provided one (if that is guaranteed to be latest). Can you create a tech debt issue, maybe just generally about removing the need to add entries manually? |
@richard-cox We created rancher/dashboard#10849 to see if we can address this moving forward |
fixes rancher/dashboard#10806
This PR adds Docker 24.0.x support - so when 24 is added, this will come from the backend as the default version and will be added to the list. Docker 24 is currently the default, so adding 24 here will ensure that when it is no longer the default, it will continue to be listed.
Code added in the previous release ensures that if a hard-code entry in the list is also the default, it will only be shown once.