Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CSI and CPI chart image versions #35

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Update CSI and CPI chart image versions #35

merged 3 commits into from
Nov 8, 2022

Conversation

a-blender
Copy link
Contributor

@a-blender a-blender commented Oct 27, 2022 •
edited
Loading

Pull Request Checklist

  • Any new images or tags consumed by charts has been added here
  • That helm lint and pack run successfully on the chart.
  • Deployment of the chart has been tested and verified that it functions as expected.
  • Changes to scripting or CI config have been tested to the best of your ability - NA

Types of Change

Image version update

  • CSI 2.5.3, 2.6.1 -> 2.5.4, 2.6.2, 2.7.0
  • CPI 1.24.1 -> 1.24.2, 1.25.0

Linked Issues

rancher/rancher#38188
rancher/rancher#38187

jiaqiluo
jiaqiluo requested changes Oct 27, 2022
View reviewed changes
Copy link
Member

@jiaqiluo jiaqiluo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but will approve after CI is passed

brandond
brandond requested changes Oct 27, 2022
View reviewed changes
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the values and everything below it appear to all be over-indented by two spaces.

charts/rancher-vsphere-cpi/values.yaml Outdated Show resolved Hide resolved
snasovich
snasovich previously approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@snasovich snasovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation issue to address.

Also, this links to CSI issue only but also updates CPI image versions. Please link to the CPI issue as well.

charts/rancher-vsphere-csi/values.yaml Outdated Show resolved Hide resolved
@snasovich snasovich self-requested a review October 28, 2022 14:47
@snasovich snasovich dismissed their stale review October 28, 2022 14:47

Accidental approval, was supposed to just comment.

brandond
brandond previously approved these changes Oct 31, 2022
View reviewed changes
@brandond
Copy link
Member

Does one of the tests need to be updated?

    csi_template_test.go:258: 
        	Error Trace:	csi_template_test.go:258
        	Error:      	Not equal: 
        	            	expected: "rancher/mirrored-cloud-provider-vsphere-csi-release-driver:v2.5.4"
        	            	actual  : "rancher/mirrored-cloud-provider-vsphere-csi-release-driver:v2.5.3"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-rancher/mirrored-cloud-provider-vsphere-csi-release-driver:v2.5.4
        	            	+rancher/mirrored-cloud-provider-vsphere-csi-release-driver:v2.5.3
        	Test:       	TestCSITemplateRenderedNodeDaemonset/Kubernetes_1.21_Linux_and_Windows#01
--- FAIL: TestCSITemplateRenderedNodeDaemonset (0.83s)
    --- PASS: TestCSITemplateRenderedNodeDaemonset/Kubernetes_1.25_Linux_Only (0.07s)
    --- PASS: TestCSITemplateRenderedNodeDaemonset/Kubernetes_1.25_Linux_and_Windows (0.06s)
    --- PASS: TestCSITemplateRenderedNodeDaemonset/Kubernetes_1.24_Linux_Only (0.07s)
    --- PASS: TestCSITemplateRenderedNodeDaemonset/Kubernetes_1.24_Linux_and_Windows (0.07s)
    --- FAIL: TestCSITemplateRenderedNodeDaemonset/Kubernetes_1.23_Linux_Only (0.07s)
    --- FAIL: TestCSITemplateRenderedNodeDaemonset/Kubernetes_1.23_Linux_and_Windows (0.07s)
    --- FAIL: TestCSITemplateRenderedNodeDaemonset/Kubernetes_1.22_Linux_Only (0.07s)
    --- FAIL: TestCSITemplateRenderedNodeDaemonset/Kubernetes_1.22_Linux_and_Windows (0.07s)
    --- FAIL: TestCSITemplateRenderedNodeDaemonset/Kubernetes_1.21_Linux_Only (0.08s)
    --- FAIL: TestCSITemplateRenderedNodeDaemonset/Kubernetes_1.21_Linux_and_Windows (0.07s)
    --- PASS: TestCSITemplateRenderedNodeDaemonset/Kubernetes_1.20_Linux_Only (0.07s)
    --- FAIL: TestCSITemplateRenderedNodeDaemonset/Kubernetes_1.21_Linux_and_Windows#01 (0.07s)

jiaqiluo
jiaqiluo approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@jiaqiluo jiaqiluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@a-blender a-blender mentioned this pull request Nov 1, 2022
Closed
@rayandas rayandas mentioned this pull request Nov 4, 2022
Closed
@rayandas
Copy link
Contributor

rayandas commented Nov 4, 2022

Can we merge this PR please? CSI chart update rancher/charts#2190 depends on this PR.
@jiaqiluo @annablender

@a-blender a-blender merged commit 9cc0ecd into rancher:main Nov 8, 2022
This was referenced Nov 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

@jiaqiluo jiaqiluo jiaqiluo approved these changes

@kinarashah kinarashah Awaiting requested review from kinarashah

@snasovich snasovich Awaiting requested review from snasovich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@a-blender @brandond @rayandas @jiaqiluo @snasovich