fix the mutation and validation in v3 mgmt cluster #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a KEv2 cluster (GKE/EKS/AKS) or v1 Provisioning Cluster
KevinJoiner
approved these changes
Jan 5, 2023
jakefhyde
reviewed
Jan 5, 2023
| return admission.ResponseAllowed(), nil | ||
| } | ||
| if cluster.Spec.RancherKubernetesEngineConfig == nil { |
There was a problem hiding this comment.
Is it possible to check the cluster driver here or is it not populated yet? I'm going to approve so as to unblock CI that's failing because of this.
There was a problem hiding this comment.
It is doable but unnecessary because we need to skip it anyway.
jakefhyde
approved these changes
Jan 5, 2023
jiaqiluo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.