add support for ubuntu, docker install, and 1.25+ #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slickwarren
force-pushed
the
cwarren/ubuntu-support
branch
from
32a31ac
to
5721e41
Compare
slickwarren
force-pushed
the
cwarren/ubuntu-support
branch
from
5721e41
to
66f9da8
Compare
igomez06
reviewed
Aug 7, 2023
slickwarren
force-pushed
the
cwarren/ubuntu-support
branch
from
66f9da8
to
a95fa68
Compare
slickwarren
force-pushed
the
cwarren/ubuntu-support
branch
from
a95fa68
to
58e3585
Compare
|
closing in favor of #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rancher install on 1.25+ requires
global.cattle.psp.enabled== false. Added a check in the shell script to add this option if user is on 1.25+currently, base VM (in this case, the ami in aws-ec2) is expected to already have docker installed. Adding option to allow docker install via cloud config
corral_ssh_key_type allows non-rsa key, ed25519 to be used (see this supporting corral PR)
local testing: