Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend documentation for encryption and signing parameters #3823

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

lieser
Copy link
Collaborator

@lieser lieser commented Dec 8, 2023

No description provided.

@lieser lieser added this to the Botan 3.3.0 milestone Dec 8, 2023
@lieser lieser requested a review from reneme December 8, 2023 13:37
@lieser lieser self-assigned this Dec 8, 2023
@reneme
Copy link
Collaborator

reneme commented Dec 8, 2023

Nice! This information would have been so helpful for me personally when i started out with Botan. Thanks for the effort!

(Apparently GitHub has some issues with the comments/review UI right now; hence actual review will have to wait.)

@coveralls
Copy link

coveralls commented Dec 8, 2023

Coverage Status

coverage: 92.058% (+0.003%) from 92.055%
when pulling 78f9a86 on pl/pubkey_doc
into 7bc2b1c on master.

doc/api_ref/pubkey.rst Outdated Show resolved Hide resolved
Takes the optional parameter ``Deterministic`` (default) or ``Randomized``.
#. SPHINCS+.
Takes the optional parameter ``Deterministic`` (default) or ``Randomized``.
#. XMSS. Takes no parameter.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must not forget to amend that for LMS in #3716.

Copy link
Collaborator Author

@lieser lieser Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update it after this is merged

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@lieser lieser merged commit e3b7dc3 into master Dec 8, 2023
38 checks passed
@lieser lieser deleted the pl/pubkey_doc branch December 8, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants