fixed retransmission handled ClientHello with another protocol version. #4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
reviewed
May 1, 2024
volok-aleksej
force-pushed
the
master
branch
3 times, most recently
from
9ff9096
to
36dead2
Compare
|
Hi, Guys, what is progress? I have updated own master branch, therefor need aprove ci again. Sorry, I'll be waiting for you. |
volok-aleksej
force-pushed
the
master
branch
2 times, most recently
from
f9448ec
to
a686ab4
Compare
|
@volok-aleksej I need to refresh my memory of the RFC here, I'll review tonight |
|
@reneme Tagging you just as an FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to https://www.rfc-editor.org/rfc/rfc9147.html#section-4-6.2
for all ClientHello we have to ignore checking protocol version on record layer, real version of protocol we have checking on handshake layer as well as the checking retransmitted messages.