Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build self_hash up from INLINE_STYLES #72

Merged
merged 1 commit into from
Apr 1, 2012
Merged

Conversation

joekain
Copy link
Collaborator

@joekain joekain commented Mar 31, 2012

Iterate over each value in INLINE_STYLES instead of iterating over
each value in instances_values and rejecting unwanted items. This
version proceses fewer values and runs a little faster.

Issue #61 - Axlsx performance

Iterate over each value in INLINE_STYLES instead of iterating over
each value in instances_values and rejecting unwanted items.  This
version proceses fewer values and runs a little faster.

Issue randym#61 - Axlsx performance
@joekain
Copy link
Collaborator Author

joekain commented Mar 31, 2012

I took a look at performance for the use_shared_strings as discussed in Issue #61. This improves performance by about 12% for me in the axlsx_shared portion of the benchmark in issue #61.

@joekain joekain mentioned this pull request Apr 1, 2012
randym added a commit that referenced this pull request Apr 1, 2012
Build self_hash up from INLINE_STYLES
@randym randym merged commit b11537d into randym:master Apr 1, 2012
@randym
Copy link
Owner

randym commented Apr 1, 2012

Thanks mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants