Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get the coverage numbers respectable #12

Closed
randytarampi opened this issue Aug 3, 2018 · 0 comments
Closed

Get the coverage numbers respectable #12

randytarampi opened this issue Aug 3, 2018 · 0 comments
Assignees
@randytarampi
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
Get test coverage...

Comments

@randytarampi
Copy link
Owner

What is it that they say? Good habits beget good software?

Ideally we get back in the totally arbitrarily defined thresholds I set back in the day.
@randytarampi randytarampi added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 3, 2018
randytarampi added a commit that referenced this issue Aug 3, 2018
@randytarampi
feat(jsx): Handle the HTML returned in tumblr photo captions.
177a9d9 
Just hack at the `<p>` tags and insert `<span>`s into them. A hack sure, but it's definitely an improvement. Feel bad about no tests and committing directly on master though, but I made #12 to shame me for next time.

Closes randytarampi/me.photos#17. Finally. Lol.
randytarampi added a commit that referenced this issue Aug 4, 2018
@randytarampi
test(jsx): Export a bunch more things to make the coverage calculatio…
ebf16e6 
…n more accurate.

Setup for #12 and also see if `test` bumps the build version. Don't assume it will but you never know until you try or read the docs.
@randytarampi randytarampi reopened this Aug 4, 2018
@randytarampi randytarampi mentioned this issue Aug 4, 2018
Closed
randytarampi added a commit that referenced this issue Aug 8, 2018
@randytarampi
ci(posts): import all lambdas for more accurate code coverage numbers.
7b14c5f 
Making progress towards #12.

Signed-off-by: Randy Tarampi <rt@randytarampi.ca>
randytarampi added a commit that referenced this issue Aug 8, 2018
@randytarampi
ci(posts): import all lambdas for more accurate code coverage numbers.
652c462 
Making progress towards #12.

Signed-off-by: Randy Tarampi <rt@randytarampi.ca>
@randytarampi randytarampi added the ready Issues ready to be worked on label Aug 8, 2018
randytarampi added a commit that referenced this issue Aug 8, 2018
@randytarampi
ci(posts): import all lambdas for more accurate code coverage numbers.
7bbdfe2 
Making progress towards #12.

Signed-off-by: Randy Tarampi <rt@randytarampi.ca>
randytarampi added a commit that referenced this issue Aug 8, 2018
@randytarampi
ci(posts): import all lambdas for more accurate code coverage numbers.
4b4372a 
Making progress towards #12.

Signed-off-by: Randy Tarampi <rt@randytarampi.ca>
randytarampi added a commit that referenced this issue Aug 9, 2018
@randytarampi
ci(posts): import all lambdas for more accurate code coverage numbers.
a48f3ef 
Making progress towards #12.

Signed-off-by: Randy Tarampi <rt@randytarampi.ca>
randytarampi added a commit that referenced this issue Aug 9, 2018
@randytarampi
fix(posts): Add test coverage for the S3 and Tumblr WordSources.
f703f60 
Progress on #12.
randytarampi added a commit that referenced this issue Aug 9, 2018
@randytarampi
fix(posts): Add test coverage for the PhotoSources.
e0e50ec 
Progress on #12.
@randytarampi randytarampi mentioned this issue Aug 9, 2018
Merged
randytarampi added a commit that referenced this issue Aug 11, 2018
@randytarampi
test(jsx): Export a bunch more things to make the coverage calculatio…
edde377 
…n more accurate.

Setup for #12 and also see if `test` bumps the build version. Don't assume it will but you never know until you try or read the docs.
randytarampi added a commit that referenced this issue Aug 15, 2018
@randytarampi
fix(posts): Add test coverage for the S3 and Tumblr WordSources.
c18be85 
Progress on #12.
@randytarampi randytarampi mentioned this issue Aug 15, 2018
Closed
randytarampi added a commit that referenced this issue Aug 17, 2018
@randytarampi
ci(letter): Add some tests for assembleLetter and renderHtml.
630e76c 
Try not to fall behind on #12 – it's SSRed anyways, so why not?
randytarampi added a commit that referenced this issue Aug 20, 2018
@randytarampi
feat(posts): getPosts actually pulls Posts from the cache, "prope…
3d1f54b 
…rly". (#49, #50)

Close #49 & #50.

Added a bunch of view code, and coverage went down. Guess I should really get on #12...
@randytarampi randytarampi mentioned this issue Aug 23, 2018
Merged
randytarampi added a commit that referenced this issue Aug 23, 2018
@randytarampi
feat(posts): getPosts actually pulls Posts from the cache, "prope…
2a2fed8 
…rly". (#49, #50)

Close #49 & #50.

Added a bunch of view code, and coverage went down. Guess I should really get on #12...
randytarampi added a commit that referenced this issue Aug 23, 2018
@randytarampi
feat(www): Rework Post fetching and state management. (#51)
620be7d 
Close randytarampi/me.photos#15, close randytarampi/me.photos#11 and close randytarampi/me.words#1 and make progress on #23 and #12.

Using the word `close` because that's what the wafflebot is looking for.
randytarampi added a commit that referenced this issue Aug 23, 2018
@randytarampi
feat(posts): getPosts actually pulls Posts from the cache, "prope…
d80eec3 
…rly". (#49, #50)

Close #49 & #50.

Added a bunch of view code, and coverage went down. Guess I should really get on #12...
randytarampi added a commit that referenced this issue Aug 23, 2018
@randytarampi
feat(posts): getPosts actually pulls Posts from the cache, "prope…
3228aeb 
…rly". (#49, #50)

Close #49 & #50.

Added a bunch of view code, and coverage went down. Guess I should really get on #12...
randytarampi added a commit that referenced this issue Aug 24, 2018
@randytarampi
feat(resume): Add a volunteer section, if only for #12.
ce647f5 
I mean, it's on my LinkedIn. Ancient but at least it adds to my overall coverage numbers.
@randytarampi randytarampi mentioned this issue Aug 24, 2018
Merged
randytarampi added a commit that referenced this issue Aug 24, 2018
@randytarampi
feat(posts): getPosts actually pulls Posts from the cache, "prope…
50554b0 
…rly". (#49, #50)

Close #49 & #50.

Added a bunch of view code, and coverage went down. Guess I should really get on #12...
randytarampi added a commit that referenced this issue Aug 31, 2018
@randytarampi
chore(www): Wean ourselves off needing the getPhotos and getWords…
3a0a708 
… handlers in `posts`.

I mean, they're free to run and deploy, but removing them is the easiest way to pursue #12 in `posts` right now.

Gonna push this directly to master, wait for the deploys, then remove the handlers. Anyone with a long lived cached copy is probably SOL, but really how many people could that be on this long weekend?
randytarampi added a commit that referenced this issue Sep 1, 2018
@randytarampi
chore(js): Bring the coverage up to watermarks I enabled in 8a8d5e9.
842958c 
Per #12.
randytarampi added a commit that referenced this issue Sep 1, 2018
@randytarampi
chore(posts): Bring the coverage numbers up per #12.
669a96b
randytarampi added a commit that referenced this issue Sep 1, 2018
@randytarampi
feat(posts): Actually load *all* Posts from each service per #73. (#85)
f769364 
Close #73 and push forward on #12.
randytarampi added a commit that referenced this issue Sep 2, 2018
@randytarampi
chore(posts): Combine (word|photo)Sources per #75.
534365b 
Some huge wins on #12 here I think.
randytarampi added a commit that referenced this issue Sep 4, 2018
@randytarampi
chore(jsx): Add test coverage per #12.
5677d29 
Finally get around to writing some enzyme tests. Lol.

Cover everything *but* the component code for now.
randytarampi added a commit that referenced this issue Sep 4, 2018
@randytarampi
chore(posts): Bring the coverage numbers up per #12.
8ed5057
randytarampi added a commit that referenced this issue Sep 4, 2018
@randytarampi
chore(jsx): Add test coverage per #12.
a2ee61f 
Finally get around to writing some enzyme tests. Lol.

Cover everything *but* the component code for now.
randytarampi added a commit that referenced this issue Sep 4, 2018
@randytarampi
chore(jsx): Add test coverage per #12.
d0b84ae 
Finally get around to writing some enzyme tests. Lol.

Cover everything *but* the component code for now.
randytarampi added a commit that referenced this issue Sep 4, 2018
@randytarampi
chore(jsx): Add test coverage per #12.
8f843b4 
Finally get around to writing some enzyme tests. Lol.

Cover everything *but* the component code for now.
randytarampi added a commit that referenced this issue Sep 4, 2018
@randytarampi
fix(jsx): Add tests for some mostly stable components. Per #12.
88abca3 
I'm passing on `Link`s and `printable`s for now. It's just not worth it with how simple and unstable they are at the moment, respectively (of course).

Also fix some styling regressions introduced when I got rid of `.photo` styles and collapsed them into `.post`.
randytarampi added a commit that referenced this issue Sep 4, 2018
@randytarampi
chore(jsx): Add test coverage per #12.
5406dc0 
Finally get around to writing some enzyme tests. Lol.

Cover everything *but* the component code for now.
randytarampi added a commit that referenced this issue Sep 5, 2018
@randytarampi
chore(jsx): Add test coverage per #12.
d611848 
Finally get around to writing some enzyme tests. Lol.

Cover everything *but* the component code for now.
randytarampi added a commit that referenced this issue Sep 5, 2018
@randytarampi
chore(jsx): Turn on check-coverage per #87 & #12.
2e29840 
Close #87.
randytarampi added a commit that referenced this issue Sep 5, 2018
@randytarampi
chore(jsx): Add test coverage per #12.
508171f 
Finally get around to writing some enzyme tests. Lol.

Cover everything *but* the component code for now.
@randytarampi randytarampi mentioned this issue Sep 5, 2018
Open
randytarampi added a commit that referenced this issue Sep 5, 2018
@randytarampi
chore(jsx): Add test coverage per #12.
d574ef3 
Finally get around to writing some enzyme tests. Lol.

Cover everything *but* the component code for now.
randytarampi added a commit that referenced this issue Sep 6, 2018
@randytarampi
chore(jsx): Add test coverage per #12.
ad14be5 
Finally get around to writing some enzyme tests. Lol.

Cover everything *but* the component code for now.
randytarampi added a commit that referenced this issue Sep 6, 2018
@randytarampi
chore(jsx): Add test coverage per #12.
afa5a20 
Finally get around to writing some enzyme tests. Lol.

Cover everything *but* the component code for now.
randytarampi added a commit that referenced this issue Sep 7, 2018
@randytarampi
chore(jsx): Add test coverage per #12.
402c539 
Finally get around to writing some enzyme tests. Lol.

Cover everything *but* the component code for now.
@ghost ghost removed the in progress Issues with solutions in progress label Sep 9, 2018
randytarampi added a commit that referenced this issue Sep 9, 2018
@randytarampi
chore(www): Add some test coverage and close #88.
6ca0c26 
And close #12 while we're at it. 🎉

And now to handle the code climate...
randytarampi added a commit that referenced this issue Sep 9, 2018
@randytarampi
chore(www): Add some test coverage and close #88.
2857c4f 
And close #12 while we're at it. 🎉

And now to handle the code climate...
randytarampi added a commit that referenced this issue Sep 9, 2018
@randytarampi
chore(www): Add some test coverage and close #88.
11b8871 
And close #12 while we're at it. 🎉

And now to handle the code climate...
randytarampi added a commit that referenced this issue Sep 10, 2018
@randytarampi
chore(www): Add some test coverage and close #88.
24c2477 
And close #12 while we're at it. 🎉

And now to handle the code climate...
randytarampi added a commit that referenced this issue Sep 10, 2018
@randytarampi
chore(www): Add some test coverage and close #88.
4ab2939 
And close #12 while we're at it. 🎉

And now to handle the code climate...
randytarampi added a commit that referenced this issue Sep 10, 2018
@randytarampi
chore(www): Add some test coverage and close #88.
49a667e 
And close #12 while we're at it. 🎉

And now to handle the code climate...
randytarampi added a commit that referenced this issue Sep 11, 2018
@randytarampi
chore(www): Add some test coverage and close #88.
d8c013e 
And close #12 while we're at it. 🎉

And now to handle the code climate...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@randytarampi randytarampi

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
Get test coverage numbers respectable
Development

No branches or pull requests
1 participant
@randytarampi