feat(resume): Migrateresume to use react components.
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng a `logger`. 'cause we won't if we try and do SSR.
…be shared. 'cause we'll want some of these URLs in `resume`.
So `resume` can use them.
And also `ReduxRoot` -> `ClientReduxRoot`. The idea here is that I'm going to be using react SSR to generate the resume HTML. Can't just have this render client side as I would like to retain the ability to generate PDFs, and I don't see why Phantom should have to load and execute JS.
For consistency with `www`. Ideally we can just pull `resume` into it and serve it at `www.randytarampi.ca/resume`.
These should only show up on the `gh-pages` branch, after they're built and committed by Travis.
Turns out that webpack's HMR is tricked by having existing JS bundles being served from a root directory. Hot reloading will work for a file available at `/dist/foo.js` but not for one at `/foo.js`.
randytarampi
added
enhancement
Pull Request Test Coverage Report for Build 182
💛 - Coveralls |
ghost
removed
the
randytarampi
added a commit
that referenced
this pull request
Aug 4, 2018
randytarampi
added a commit
that referenced
this pull request
Aug 4, 2018
randytarampi
added a commit
that referenced
this pull request
Aug 4, 2018
randytarampi
added a commit
that referenced
this pull request
Aug 4, 2018
randytarampi
added a commit
that referenced
this pull request
Aug 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of Handlebars, to promote code reuse and facilitate the serving of it at https://www.randytarampi.ca/resume.