-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Checkout [check-run-reporter](https://www.check-run-reporter.com/docs)'s reporting. #683
Conversation
Best reviewed: commit by commit
Optimal code review plan
|
863f582
to
0675f33
Compare
JUnit is a fickle beast :) It looks like ESLint changed their JUnit report format since I implemented its parser. You'll get better results for ESLint using the json-with-metadata outputer. Do you mind if I add your failed test reports to the test suite in order to fix the parse errors you're seeing? |
Haha. Go for it. |
Fixes for both eslint and mocha JUnit parsing have been deployed. Hopefully that'll get you unblocked. Thanks for your patience! |
f1e0f34
to
78f3d00
Compare
Pull Request Test Coverage Report for Build 3562
💛 - Coveralls |
Looks like |
ac0d4d5
to
d2c1d1d
Compare
…om/docs)'s reporting. Just opting for the basic JUnit ESLint output for now, but maybe we'll go down a different reporting route, so let's cross that bridge when we get there...
d2c1d1d
to
42cf9a1
Compare
Code Climate has analyzed commit 42cf9a1 and detected 13 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.5%. View more on Code Climate. |
That way we always report `pretest` failures. Right?
Just opting for the basic JUnit ESLint output for now, but maybe we'll go down a different reporting route, so let's cross that bridge when we get there...