Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Checkout [check-run-reporter](https://www.check-run-reporter.com/docs)'s reporting. #683

Merged
merged 2 commits into from
Jan 13, 2020

Conversation

randytarampi
Copy link
Owner

Just opting for the basic JUnit ESLint output for now, but maybe we'll go down a different reporting route, so let's cross that bridge when we get there...

@randytarampi randytarampi added the enhancement New feature or request label Jan 11, 2020
@randytarampi randytarampi self-assigned this Jan 11, 2020
@pull-assistant
Copy link

pull-assistant bot commented Jan 11, 2020

Score: 0.99

Best reviewed: commit by commit


Optimal code review plan

     chore: Checkout [check-run-reporter](https://www.check-run-reporter.co...

     chore(travis): Run our pretests during the script phase.

Powered by Pull Assistant. Last update 42cf9a1 ... fa9d8e8. Read the comment docs.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@randytarampi randytarampi force-pushed the chore/checkout-check-run-reporter branch 2 times, most recently from 863f582 to 0675f33 Compare January 11, 2020 19:56
@ianwremmel
Copy link

JUnit is a fickle beast :)

It looks like ESLint changed their JUnit report format since I implemented its parser. You'll get better results for ESLint using the json-with-metadata outputer. Do you mind if I add your failed test reports to the test suite in order to fix the parse errors you're seeing?

@randytarampi
Copy link
Owner Author

Haha. Go for it.

@ianwremmel
Copy link

Fixes for both eslint and mocha JUnit parsing have been deployed. Hopefully that'll get you unblocked. Thanks for your patience!

@randytarampi randytarampi force-pushed the chore/checkout-check-run-reporter branch 2 times, most recently from f1e0f34 to 78f3d00 Compare January 12, 2020 16:08
@coveralls
Copy link

coveralls commented Jan 12, 2020

Pull Request Test Coverage Report for Build 3562

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.528%

Totals Coverage Status
Change from base Build 3560: 0.0%
Covered Lines: 3381
Relevant Lines: 3537

💛 - Coveralls

@ianwremmel
Copy link

Looks like COMMIT_SHA without a leading $ snuck back into the code somewhere. There'll be a change shortly that sends that error back to you instead of forcing me to reach out :)

@randytarampi randytarampi force-pushed the chore/checkout-check-run-reporter branch 4 times, most recently from ac0d4d5 to d2c1d1d Compare January 12, 2020 19:03
…om/docs)'s reporting.

Just opting for the basic JUnit ESLint output for now, but maybe we'll go down a different reporting route, so let's cross that bridge when we get there...
@randytarampi randytarampi force-pushed the chore/checkout-check-run-reporter branch from d2c1d1d to 42cf9a1 Compare January 12, 2020 19:04
@codeclimate
Copy link

codeclimate bot commented Jan 12, 2020

Code Climate has analyzed commit 42cf9a1 and detected 13 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 13

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.5%.

View more on Code Climate.

That way we always report `pretest` failures. Right?
@randytarampi randytarampi merged commit 5d0f5b2 into master Jan 13, 2020
@randytarampi randytarampi deleted the chore/checkout-check-run-reporter branch January 13, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants