Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade isomorphic-fetch from 2.2.1 to 3.0.0 #751

Closed
wants to merge 1 commit into from

Conversation

snyk-bot
Copy link
Contributor

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

merge advice

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • packages/service/package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Issue Breaking Change Exploit Maturity
medium severity Denial of Service
SNYK-JS-NODEFETCH-674311
Yes No Known Exploit
Commit messages
Package name: isomorphic-fetch The new version differs by 12 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

@codeclimate
Copy link

codeclimate bot commented Oct 17, 2020

Code Climate has analyzed commit 2d78c0d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.6% (0.0% change).

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #751 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #751   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files         363      363           
  Lines        3743     3743           
  Branches      309      309           
=======================================
  Hits         3528     3528           
  Misses        175      175           
  Partials       40       40           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f1f70...2d78c0d. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4258

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.515%

Totals Coverage Status
Change from base Build 4255: 0.0%
Covered Lines: 3397
Relevant Lines: 3552

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Oct 17, 2020

Pull Request Test Coverage Report for Build 4258

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.515%

Totals Coverage Status
Change from base Build 4255: 0.0%
Covered Lines: 3397
Relevant Lines: 3552

💛 - Coveralls

@randytarampi
Copy link
Owner

Naw. I'll do this one myself...

At some point.

I mean, this downgrade was intentional per d8f1f70...

@randytarampi randytarampi deleted the snyk-fix-22470847cbdae683f993f63d91d35344 branch October 18, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants