Skip to content
This repository has been archived by the owner on May 25, 2021. It is now read-only.

Color Settings popup should be consistent with theme #459

Closed
sumitarora opened this issue Jun 27, 2016 · 6 comments
Closed

Color Settings popup should be consistent with theme #459

sumitarora opened this issue Jun 27, 2016 · 6 comments
Assignees
Labels

Comments

@sumitarora
Copy link
Member

screen shot 2016-06-23 at 4 19 27 pm

@ericjim
Copy link
Contributor

ericjim commented Jun 27, 2016

Will something like this work? Note, I have scrollbars always present on my machine, so you'll see white stripes where overflow is present.
screen shot 2016-06-27 at 11 55 31 am

@igor-ka
Copy link

igor-ka commented Jun 27, 2016

@ericjim @sumitarora the white stripes do not work. I'd rather keep it the way it is for now if it means having white stripes in there

@ericjim
Copy link
Contributor

ericjim commented Jun 27, 2016

@igor-ka I will clarify. The whitestripes have always been there, they are only very visible as a result of a setting that I've enabled on macOS. This should not stop us from merging in this PR. @danielschifano can you comment on what things we can do to prevent the bars from appearing? I'm sure we can spot the issue if we look at the styling. My theory is that CSS is using overflow in some mode.

screen shot 2016-06-27 at 4 38 27 pm

@sumitarora
Copy link
Member Author

@igor-ka As @ericjim mentioned they are the default scrolls in Mac on browser. I don't have them enabled which is default behavior I believe. If we need to fix the scrollbars we should create another issue specific to that.

@igor-ka
Copy link

igor-ka commented Jun 28, 2016

@sumitarora @ericjim I thought that the scrollbars are "side effects" of this code. Otherwise yes, another issue makes total sense. In which case, :shipit:

@sumitarora
Copy link
Member Author

Closing issue PR already merged: #463

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants