This repository has been archived by the owner on May 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 216
Color and layout fixes and theming simplification. #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xorgy
commented
Aug 30, 2016
- Always include the expander in the state tree layout so that keys at the same level always line up.
- Always apply a theme class to to simplify theming.
- Remove all app.css theme overrides.
- Move all single-use PostCSS variable values to the reference site.
- Remove all unused PostCSS variables.
- Correct tab menu light theme styles.
- Move the Router Tree outside of the , which belongs to the Component Tree.
- Remove unused node-item styles.
- Move some component-specific styles from base.css to appropriate component css files.
- Fix light theme colours.
- Use ViewChild and element refs in Header instead of querySelector and global ids.
- Wrap theme selector menu radio labels around their corresponding radio inputs so that clicking them selects the corresponding radio button.
- Remove unnecessary null check on event.target in Header.resetIfSettingOpened(), since every onclick event has a non-null target element.
- Use .transparent instead of .invisible on non-expandable state editor nodes, to prevent mouse events from being emitted.
@xorgy, thanks for your PR! By analyzing the annotation information on this pull request, we identified @sumitarora, @clbond and @danielschifano to be potential reviewers |
xorgy
force-pushed
the
style-overhaul-first-batch
branch
from
August 30, 2016 23:21
83988f7
to
3725869
Compare
@xorgy UI changes looks good few things |
@sumitarora strangely, the CI CRX build seems to be of an older version. There may be some state which is preventing it from building the new version. |
xorgy
force-pushed
the
style-overhaul-first-batch
branch
2 times, most recently
from
August 31, 2016 17:28
5422768
to
3ed3c3d
Compare
@sumitarora I just tested the CI CRX from this, and it is functioning as expected. The Show HTML elements toggle is working as well. |
xorgy
force-pushed
the
style-overhaul-first-batch
branch
from
August 31, 2016 19:48
3ed3c3d
to
74a9003
Compare
- Always include the expander in the state tree layout so that keys at the same level always line up. - Always apply a theme class to <bt-app> to simplify theming. - Remove all app.css theme overrides. - Move all single-use PostCSS variable values to the reference site. - Remove all unused PostCSS variables. - Correct tab menu light theme styles. - Move the Router Tree outside of the <split-pane>, which belongs to the Component Tree. - Remove unused node-item styles. - Move some component-specific styles from base.css to appropriate component css files. - Fix light theme colours. - Use ViewChild and element refs in Header instead of querySelector and global ids. - Wrap theme selector menu radio labels around their corresponding radio inputs so that clicking them selects the corresponding radio button. - Remove unnecessary null check on event.target in Header.resetIfSettingOpened(), since every onclick event has a non-null target element. - Use .transparent instead of .invisible on non-expandable state editor nodes, to prevent mouse events from being emitted.
xorgy
force-pushed
the
style-overhaul-first-batch
branch
from
August 31, 2016 20:13
74a9003
to
a7fb8dd
Compare
@xorgy LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.