Skip to content
This repository has been archived by the owner on May 25, 2021. It is now read-only.

Color and layout fixes and theming simplification. #580

Merged
merged 1 commit into from
Aug 31, 2016

Conversation

xorgy
Copy link
Contributor

@xorgy xorgy commented Aug 30, 2016

  • Always include the expander in the state tree layout so that keys at the same level always line up.
  • Always apply a theme class to to simplify theming.
  • Remove all app.css theme overrides.
  • Move all single-use PostCSS variable values to the reference site.
  • Remove all unused PostCSS variables.
  • Correct tab menu light theme styles.
  • Move the Router Tree outside of the , which belongs to the Component Tree.
  • Remove unused node-item styles.
  • Move some component-specific styles from base.css to appropriate component css files.
  • Fix light theme colours.
  • Use ViewChild and element refs in Header instead of querySelector and global ids.
  • Wrap theme selector menu radio labels around their corresponding radio inputs so that clicking them selects the corresponding radio button.
  • Remove unnecessary null check on event.target in Header.resetIfSettingOpened(), since every onclick event has a non-null target element.
  • Use .transparent instead of .invisible on non-expandable state editor nodes, to prevent mouse events from being emitted.

@mention-bot
Copy link

@xorgy, thanks for your PR! By analyzing the annotation information on this pull request, we identified @sumitarora, @clbond and @danielschifano to be potential reviewers

@sumitarora
Copy link
Member

@xorgy UI changes looks good few things Show HTML elements is not working

@xorgy
Copy link
Contributor Author

xorgy commented Aug 31, 2016

@sumitarora strangely, the CI CRX build seems to be of an older version. There may be some state which is preventing it from building the new version.

@xorgy xorgy force-pushed the style-overhaul-first-batch branch 2 times, most recently from 5422768 to 3ed3c3d Compare August 31, 2016 17:28
@xorgy
Copy link
Contributor Author

xorgy commented Aug 31, 2016

@sumitarora I just tested the CI CRX from this, and it is functioning as expected. The Show HTML elements toggle is working as well.

@xorgy xorgy force-pushed the style-overhaul-first-batch branch from 3ed3c3d to 74a9003 Compare August 31, 2016 19:48
 - Always include the expander in the state tree layout so that keys at the same level always line up.
 - Always apply a theme class to <bt-app> to simplify theming.
 - Remove all app.css theme overrides.
 - Move all single-use PostCSS variable values to the reference site.
 - Remove all unused PostCSS variables.
 - Correct tab menu light theme styles.
 - Move the Router Tree outside of the <split-pane>, which belongs to the Component Tree.
 - Remove unused node-item styles.
 - Move some component-specific styles from base.css to appropriate component css files.
 - Fix light theme colours.
 - Use ViewChild and element refs in Header instead of querySelector and global ids.
 - Wrap theme selector menu radio labels around their corresponding radio inputs so that clicking them selects the corresponding radio button.
 - Remove unnecessary null check on event.target in Header.resetIfSettingOpened(), since every onclick event has a non-null target element.
 - Use .transparent instead of .invisible on non-expandable state editor nodes, to prevent mouse events from being emitted.
@xorgy xorgy force-pushed the style-overhaul-first-batch branch from 74a9003 to a7fb8dd Compare August 31, 2016 20:13
@igor-ka
Copy link

igor-ka commented Aug 31, 2016

@xorgy LGTM :shipit:

@xorgy xorgy merged commit 8b4e099 into rangle:dev Aug 31, 2016
@xorgy xorgy deleted the style-overhaul-first-batch branch October 19, 2016 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants