test: fix runCommand when path has spaces #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `node "${qnmBin}"` instead of `${qnmBin}` directly to solve two issues:
- Tests failed when absolute path of qnm repository has spaces. Example:
`/path/i have spaces/qnm`
- `bin/qnm.js` is not always made executable when cloned on windows to rely on node shebang.
Note: `""` instead of `''` to escape spaces on Windows too.
ranyitz
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
node "${qnmBin}"instead of${qnmBin}directly to solve two issues:/path/i have spaces/qnmbin/qnm.jsis not always made executable when cloned on windows to rely on node shebang.Note:
""instead of''to escape spaces on Windows too.