Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstrings and rerun #7

Conversation

akapet00
Copy link
Contributor

Hi,

This PR fixes the following issues regarding the recent notebook:

  • a few typos in comments;
  • a docstring error in hodgkin_huxley_model, should be args : list instead of kwargs : dict, so from this:
def hodgkin_huxley_model(y0, t, A, t_start, t_stop, *args):
    """Return the change in state variables of the neuron.

    Parameters
    ----------
    (...)
    kwargs : dict
        (...)
    """

to this:

def hodgkin_huxley_model(y0, t, A, t_start, t_stop, *args):
    """Return the change in state variables of the neuron.

    Parameters
    ----------
    (...)
    args : list
        (...)
    """
  • finally, I did some slight changes in visualization code to be more consistent with previous two notebooks.

@raphaelvallat raphaelvallat merged commit 1c88353 into raphaelvallat:master Jun 18, 2021
@akapet00 akapet00 deleted the fix_complexity_corr_membrane_potential branch June 18, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants