Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for noncentrality parameters. #347

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

agkphysics
Copy link
Contributor

Fixes #343, caused by scipy/scipy#17916.

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (c22843f) 98.54% compared to head (c9d7773) 98.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
+ Coverage   98.54%   98.55%   +0.01%     
==========================================
  Files          19       19              
  Lines        3361     3390      +29     
  Branches      547      559      +12     
==========================================
+ Hits         3312     3341      +29     
  Misses         26       26              
  Partials       23       23              
Impacted Files Coverage Δ
pingouin/power.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@agkphysics
Copy link
Contributor Author

I notice that coverage fails because of the greater and less paths. Do you want me to add these extra test cases for ttest and ttest2n?

@raphaelvallat
Copy link
Owner

Hi @agkphysics,

This is great, thank you! Yes can you please add the extra test?

Btw I see that scipy/scipy#17916 has now been fixed and should be included in scipy 1.11.0.

@agkphysics
Copy link
Contributor Author

@raphaelvallat I have added the additional tests now.

Copy link
Owner

@raphaelvallat raphaelvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks so much

@raphaelvallat raphaelvallat merged commit 5c5f61a into raphaelvallat:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when calculating power with too large effect size
2 participants