-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for noncentrality parameters. #347
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 98.54% 98.55% +0.01%
==========================================
Files 19 19
Lines 3361 3390 +29
Branches 547 559 +12
==========================================
+ Hits 3312 3341 +29
Misses 26 26
Partials 23 23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I notice that coverage fails because of the |
Hi @agkphysics, This is great, thank you! Yes can you please add the extra test? Btw I see that scipy/scipy#17916 has now been fixed and should be included in scipy 1.11.0. |
Fixes raphaelvallat#343, caused by scipy/scipy#17916.
@raphaelvallat I have added the additional tests now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Thanks so much
Fixes #343, caused by scipy/scipy#17916.